Message-ID: <4C1BE722.3000006@jic23.retrosnub.co.uk>
Date: Fri, 18 Jun 2010 22:37:38 +0100
From: Jonathan Cameron <kernel@jic23.retrosnub.co.uk>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100426 Thunderbird/3.0.4
MIME-Version: 1.0
To: guenter.roeck@ericsson.com
CC: Mark Brown <broonie@opensource.wolfsonmicro.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
       Hans de Goede <hdegoede@redhat.com>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [lm-sensors] [PATCH 1/3] hwmon: Driver for SMM665 Six-Channel
 Active DC Output Controller/Monitor
References: <1276877194-28214-1-git-send-email-guenter.roeck@ericsson.com>	<1276877194-28214-2-git-send-email-guenter.roeck@ericsson.com>	<4C1BB2AC.4090308@jic23.retrosnub.co.uk> <1276894613.2631.535.camel@groeck-laptop>
In-Reply-To: <1276894613.2631.535.camel@groeck-laptop>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2040
Lines: 47

On 06/18/10 21:56, Guenter Roeck wrote:
> [...]
>>> +             /*
>>> +              * Algorithm for reading ADC, per SMM665 datasheet
>>> +              *
>>> +              *  {[S][addr][W][Ack]} {[offset][Ack]} {[S][addr][R][Nack]}
>>> +              * [wait 70 uS]
>>> +              *  {[S][addr][R][Ack]} {[datahi][Ack]} {[datalo][Ack][P]}
>>> +              *
>>> +              * To implement the first part of this exchange,
>>> +              * do a full read transaction and expect a failure/Nack.
>>> +              * This sets up the address pointer on the SMM665
>>> +              * and starts the ADC conversion.
>>> +              * Then do a two-byte read transaction.
>>> +              */
>> Is there no better way of handling this? There are protocol mangling hacks
>> to tell the i2c core to ignore a NAKs under some circumstances.
>>
>>> +             rv = i2c_smbus_read_byte_data(client, adc << 3);
>>> +             if (rv >= 0) {
>>> +                     /* No error, something is wrong. Retry. */
>>> +                     rv = -1;
>>> +                     continue;
>>> +             }
> 
> I looked through the core i2c code, but did not find anything I can
> use. 
> 
> Problem is that per smm665 specification, the first NACK is expected. So
> we do not just want to ignore this NACK, we want to actively check if
> the command "failed" as expected, and report an error if it did _not_
> fail.
> 
> Guenter
To my mind this looks like a case for adding another 'mangling' flag
to the core, but I guess that might require bus driver implementation
which would obviously be a pain.  Perhaps the approach you have taken
is the best plan.  My issue with it at the moment is that you are
detecting any error rather than specifically an unexpected NACK.


Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/