Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919Ab0FSH1w (ORCPT ); Sat, 19 Jun 2010 03:27:52 -0400 Received: from one.firstfloor.org ([213.235.205.2]:48255 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753488Ab0FSH1u (ORCPT ); Sat, 19 Jun 2010 03:27:50 -0400 Date: Sat, 19 Jun 2010 09:27:45 +0200 From: Andi Kleen To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, andi@firstfloor.org, tglx@linutronix.de, hpa@linux.intel.com Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/build] x86, vdso: Error out if the vdso contains external references Message-ID: <20100619072745.GA18946@basil.fritz.box> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 24 > diff --git a/arch/x86/vdso/checkundef.sh b/arch/x86/vdso/checkundef.sh > new file mode 100755 > index 0000000..490be1c > --- /dev/null > +++ b/arch/x86/vdso/checkundef.sh > @@ -0,0 +1,10 @@ > +#!/bin/sh > +nm="$1" > +file="$2" > +"$nm" "$file" | grep '^ *U' > /dev/null 2>&1 Does that really handle the failed inline, static function case? In this case you get a function which is not 'U', but it's just in the wrong section. I think that would need to be checked too. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/