Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754736Ab0FSIIR (ORCPT ); Sat, 19 Jun 2010 04:08:17 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]:48282 "EHLO mail-ww0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754529Ab0FSIIO convert rfc822-to-8bit (ORCPT ); Sat, 19 Jun 2010 04:08:14 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=eKT0EtR/aU+XpiOvmyImRYelNBe46sOcVTkqGgTYN/XetFaAh6IzPe3/lpACwmyWPt /OnyNc+OQFiVFzLltYVcZa3+nP83USkvKeIyOHAaYtJr7iAm/WMd4VVUPaoCbrp86jmb pR6IObXDkRLlD4wNnBIeZJmn2Tqtl3kVSC4lQ= MIME-Version: 1.0 In-Reply-To: <4C1C4FDE.2090101@gmail.com> References: <1276288869-16815-1-git-send-email-justinmattock@gmail.com> <1276288869-16815-6-git-send-email-justinmattock@gmail.com> <4C1C4FDE.2090101@gmail.com> Date: Sat, 19 Jun 2010 10:08:11 +0200 X-Google-Sender-Auth: 6guUgs4tKu_BpFoh30gxKolZc-Q Message-ID: Subject: Re: [PATCH 5/6]kernel:module.c variable 'nowarn' set but not used From: Geert Uytterhoeven To: "Justin P. Mattock" Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com, zippel@linux-m68k.org, linux-fsdevel@vger.kernel.org, rusty@rustcorp.com.au Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2274 Lines: 63 On Sat, Jun 19, 2010 at 07:04, Justin P. Mattock wrote: >> Also wrong, you removed the creation of the links in sysfs. >> >> The assignment to nowarn was there to avoid another compiler warning, >> as sysfs_create_link() is marked __must_check. > > I also went back to this one and made the following changes.. let me know if > it's wrong etc.. > > From 4f45beed80627d2bb32fb021bb6d22d88089557b Mon Sep 17 00:00:00 2001 > From: Justin P. Mattock > Date: Fri, 18 Jun 2010 22:01:07 -0700 > Subject: [PATCH 5/5] module.c >  Signed-off-by: Justin P. Mattock > > --- >  kernel/module.c |    3 +-- >  1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/kernel/module.c b/kernel/module.c > index 8c6b428..48fc5c8 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -1340,11 +1340,10 @@ static void add_usage_links(struct module *mod) >  { >  #ifdef CONFIG_MODULE_UNLOAD >        struct module_use *use; > -       int nowarn; > >        mutex_lock(&module_mutex); >        list_for_each_entry(use, &mod->target_list, target_list) { > -               nowarn = sysfs_create_link(use->target->holders_dir, > +               sysfs_create_link(use->target->holders_dir, >                                           &mod->mkobj.kobj, mod->name); >        } >        mutex_unlock(&module_mutex); > -- > 1.7.1.rc1.21.gf3bd6 > > if it looks good, then I can resend it out. Have you compile-tested this? As sysfs_create_link() is marked __must_check, that will cause another compiler warning, but only if CONFIG_SYSFS=y. Perhaps you can just mark the nowarn variable __unused? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/