DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:organization:to:subject:date:user-agent:cc:references
         :in-reply-to:mime-version:content-type:content-transfer-encoding
         :message-id;
        b=XHi40sxbBFTXwVL5DVrQbSXgOUH4db5D2D7yYoK63WtJExDofnSVurcVpOW6aqa7Wl
         GLYgamrQFjljFiKDo9Svoy7FlRHbfjZ7qa4nzZbAkyFBhIFsNqpWxSrNiSw1+fPLY6bL
         b36eVy5m2aD2DjqiAsS0bYlmp4/emAsf606U0=
From: Marek Vasut <marek.vasut@gmail.com>
Organization: Hack&Dev
To: Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] hid Logitech G13 Driver 0.0.5
Date: Sat, 19 Jun 2010 17:57:21 +0200
User-Agent: KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; )
Cc: "Rick L. Vinyard, Jr." <rvinyard@cs.nmsu.edu>,
       Jaya Kumar <jayakumar.lkml@gmail.com>, linux-kernel@vger.kernel.org,
       felipe.balbi@nokia.com, linux-usb@vger.kernel.org, oliver@neukum.org,
       linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
       npavel@ituner.com, tomi.valkeinen@nokia.com, tony@atomide.com,
       florianschandinat@gmx.de, krzysztof.h1@wp.pl, akpm@linux-foundation.org,
       linux-fbdev@vger.kernel.org, jkosina@suse.cz, bonbons@linux-vserver.org
References: <201003021848.o22ImLSS004394@mustang.cs.nmsu.edu> <24ab70ff629c48b6d10ce0cf6dc5d64b.squirrel@intranet.cs.nmsu.edu> <20100303051311.GA4651@elf.ucw.cz>
In-Reply-To: <20100303051311.GA4651@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 8BIT
Message-Id: <201006191757.22035.marek.vasut@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3459
Lines: 88

Dne St 3. března 2010 06:13:12 Pavel Machek napsal(a):
> Hi!
> 
> > >> +/*
> > >> + * This is a default logo to be loaded upon driver initialization
> > >> + * replacing the default Logitech G13 image loaded on device
> > >> + * initialization. This is to provide the user a cue that the
> > >> + * Linux driver is loaded and ready.
> > >> + *
> > >> + * This logo contains the text G13 in the center with two penguins
> > >> + * on each side of the text. The penguins are a 33x40 rendition of
> > >> + * the default framebuffer 80x80 monochrome image scaled down and
> > >> + * cleaned up to retain something that looks a little better than
> > >> + * a simple scaling.
> > >> + *
> > >> + * This logo is a simple xbm image created in GIMP and exported.
> > >> + * To view the image copy the following two #defines plus the
> > >> + * g13_lcd_bits to an ASCII text file and save with extension
> > >> + * .xbm, then open with GIMP or any other graphical editor
> > >> + * such as eog that recognizes the .xbm format.
> > >> + */
> > > 
> > > ...
> > > 
> > >> +static unsigned char g13_lcd_bits[] = {
> > >> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > >> 0x00,
> > > 
> > > I think you'll agree above is not an elegant solution.
> > 
> > I could make it a config option.
> 
> You get about 10 complains already, but you are not willing to solve
> it. No, config option does not help.
> 
> If you want to, make it separate patch so we can reject it separately.
> 
> > >> +static DEVICE_ATTR(rgb, 0666, g13_rgb_show, g13_rgb_store);
> > > 
> > > Reading above code, it looks like this new userspace sysfs attribute
> > > is for backlight control. Could that be better exposed using the
> > > existing backlight class?
> > 
> > I looked at the backlight class and it didn't seem to be a very good fit.
> > 
> > /* This structure defines all the properties of a backlight */
> > struct backlight_properties {
> > 
> > 	/* Current User requested brightness (0 - max_brightness) */
> > 	int brightness;
> > 	/* Maximal value for brightness (read-only) */
> > 	int max_brightness;
> > 	/* Current FB Power mode (0: full on, 1..3: power saving
> > 	
> > 	   modes; 4: full off), see FB_BLANK_XXX */
> > 	
> > 	int power;
> > 	/* FB Blanking active? (values as for power) */
> > 	/* Due to be removed, please use (state & BL_CORE_FBBLANK) */
> > 	int fb_blank;
> > 	/* Flags used to signal drivers of state changes */
> > 	/* Upper 4 bits are reserved for driver internal use */
> > 	unsigned int state;
> > 
> > };
> > 
> > The g13's backlight doesn't support any of these properties. All you can
> > set is an rgb value on the g13; no power modes, no brightness, etc. I
> > could add a brightness attribute by scaling the rgb values, but I would
> > prefer to do that from userspace rather than the driver since it's not
> > supported in the device itself.
> > 
> > And, we'd still have to have the rgb attribute since the backlight class
> > doesn't have color.
> 
> Or you could pretend you have 3 different backlights? ....which is
> actually what you have...?
> 									Pavel

Any updates on this?

btw. it'd be good if we could use the g13fb on G15 ... would that be possible?
Cheers!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/