Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755198Ab0FTIKd (ORCPT ); Sun, 20 Jun 2010 04:10:33 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:34399 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078Ab0FTIK1 (ORCPT ); Sun, 20 Jun 2010 04:10:27 -0400 Date: Sun, 20 Jun 2010 10:10:16 +0200 From: Ingo Molnar To: Vivek Goyal Cc: linux kernel mailing list , Jens Axboe , Divyesh Shah Subject: Re: [PATCH] cfq-iosched: Fixed boot warning with BLK_CGROUP=y and CFQ_GROUP_IOSCHED=n Message-ID: <20100620081016.GA5365@elte.hu> References: <20100618143947.GA8431@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100618143947.GA8431@redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: 1.0 X-ELTE-SpamLevel: s X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=1.0 required=5.9 tests=BAYES_50 autolearn=no SpamAssassin version=3.2.5 1.0 BAYES_50 BODY: Bayesian spam probability is 40 to 60% [score: 0.4791] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 25 * Vivek Goyal wrote: > Hi Jens, > > Few days back Ingo noticed a CFQ boot time warning. This patch fixes it. Hm, have you tested it? This bit: > +++ linux-2.6/block/cfq.h 2010-06-18 09:41:23.256220395 -0400 > +static inline void cfq_blkiocg_update_completion_stats(struct blkio_group *blkg, uint64_t start_time, uint64_t io_start_time, bool direction, bool sync) > +{ > + cfq_blkiocg_update_completion_stats(blkg, start_time, io_start_time, > + direction, sync); > +} is an inline function calling itself. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/