Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755021Ab0FTV6g (ORCPT ); Sun, 20 Jun 2010 17:58:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16600 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754519Ab0FTV6f (ORCPT ); Sun, 20 Jun 2010 17:58:35 -0400 Date: Sun, 20 Jun 2010 23:56:46 +0200 From: Oleg Nesterov To: "Eric W. Biederman" Cc: Andrew Morton , Louis Rilling , Pavel Emelyanov , Linux Containers , linux-kernel@vger.kernel.org, Daniel Lezcano Subject: Re: [PATCH 0/6] Unshare support for the pid namespace. Message-ID: <20100620215646.GB17517@redhat.com> References: <20100618082033.GD16877@hawkmoon.kerlabs.com> <20100618111554.GA3252@redhat.com> <20100618160849.GA7404@redhat.com> <20100618173320.GG16877@hawkmoon.kerlabs.com> <20100618175541.GA13680@redhat.com> <20100618212355.GA29478@redhat.com> <20100619190840.GA3424@redhat.com> <20100620180335.GA17120@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 32 On 06/20, Eric W. Biederman wrote: > > Oleg Nesterov writes: > > > And. I do not think these series can fix the discussed problems. ns->dead > > definitely can't, no? > > I'm am fairly confident that we have the signal sending races fixed so > we can reasonably expect having sent SIGKILL to all processes in a pid > namespace Sorry, didn't notice this part... Which races? I am talking about the current problems with pid_ns_release_proc(), we have at least 3 bugs, from the 2/2 changelog: - Nobody does mntput() if copy_process() fails after pid_ns_prepare_proc(). - proc_flush_task() checks upid->nr == 1 to verify we are init, this is wrong if a multi-threaded init does exec. - As Louis pointed out, this namespace can have the detached EXIT_DEAD tasks which can use ns->proc_mnt after this mntput(). Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/