Subject: Re: [patch] x86, pat: freeing invalid memtype messages
From: Peter Zijlstra <peterz@infradead.org>
To: Xiaotian Feng <dfeng@redhat.com>
Cc: Marcin Slusarz <marcin.slusarz@gmail.com>,
       Dan Carpenter <error27@gmail.com>, Thomas Gleixner <tglx@linutronix.de>,
       Ingo Molnar <mingo@redhat.com>, "H.PeterA" <"nvin hpa"@zytor.com>,
       Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
       Jack Steiner <steiner@sgi.com>,
       Suresh Siddha <suresh.b.siddha@intel.com>, linux-kernel@vger.kernel.org,
       x86@kernel.org
In-Reply-To: <4C1F455E.6050502@redhat.com>
References: <20100617134559.GA29824@bicker> <20100617161728.GA2741@joi.lan>
	 <4C1B1691.6020809@redhat.com> <20100618175726.GA2785@joi.lan>
	 <4C1F455E.6050502@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Date: Mon, 21 Jun 2010 13:02:35 +0200
Message-ID: <1277118155.1875.508.camel@laptop>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 704
Lines: 16

On Mon, 2010-06-21 at 18:56 +0800, Xiaotian Feng wrote:

> I guess there might be something wrong between the augmented rbtree insert/remove ..

The easiest thing is to revert that change and try again, the next step
would be to print the full RB tree on each modification and look where
it goes wrong.

That said, I did print my fair share of (augmented) RB trees while
playing with scheduler patches and I can't remember it ever having
messed up like that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/