Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932415Ab0FULqB (ORCPT ); Mon, 21 Jun 2010 07:46:01 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:58842 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932388Ab0FULpw (ORCPT ); Mon, 21 Jun 2010 07:45:52 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: David Rientjes Subject: Re: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed() Cc: kosaki.motohiro@jp.fujitsu.com, LKML , linux-mm , Andrew Morton , Minchan Kim , KAMEZAWA Hiroyuki In-Reply-To: References: <20100617104719.FB8C.A69D9226@jp.fujitsu.com> Message-Id: <20100617134601.FBA7.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Mon, 21 Jun 2010 20:45:45 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 807 Lines: 23 > On Thu, 17 Jun 2010, KOSAKI Motohiro wrote: > > > > > Now has_intersects_mems_allowed() has own thread iterate logic, but > > it should use while_each_thread(). > > > > It slightly improve the code readability. > > > > Reviewed-by: Minchan Kim > > Signed-off-by: KOSAKI Motohiro > > I disagree that the renaming of the variables is necessary, please simply > change the while (tsk != start) to use while_each_thread(tsk, start); This is common naming rule of while_each_thread(). please grep. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/