Subject: Re: [patch] x86, pat: freeing invalid memtype messages
From: Peter Zijlstra <peterz@infradead.org>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Xiaotian Feng <dfeng@redhat.com>, Dan Carpenter <error27@gmail.com>,
       Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
       "H.PeterA" <nvinhpa@zytor.com>, Venkatesh Pallipadi <venki@google.com>,
       Jack Steiner <steiner@sgi.com>,
       Suresh Siddha <suresh.b.siddha@intel.com>, linux-kernel@vger.kernel.org,
       x86@kernel.org
In-Reply-To: <20100621153303.GA2754@joi.lan>
References: <20100617134559.GA29824@bicker> <20100617161728.GA2741@joi.lan>
	 <4C1B1691.6020809@redhat.com> <20100618175726.GA2785@joi.lan>
	 <4C1F455E.6050502@redhat.com> <1277118155.1875.508.camel@laptop>
	 <4C1F47EF.2060509@redhat.com>  <20100621153303.GA2754@joi.lan>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Date: Mon, 21 Jun 2010 17:41:13 +0200
Message-ID: <1277134873.1875.520.camel@laptop>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1311
Lines: 28

On Mon, 2010-06-21 at 17:33 +0200, Marcin Slusarz wrote:
> On Mon, Jun 21, 2010 at 07:07:27PM +0800, Xiaotian Feng wrote:
> > On 06/21/2010 07:02 PM, Peter Zijlstra wrote:
> > > On Mon, 2010-06-21 at 18:56 +0800, Xiaotian Feng wrote:
> > >
> > >> I guess there might be something wrong between the augmented rbtree insert/remove ..
> > >
> > > The easiest thing is to revert that change and try again, the next step
> > > would be to print the full RB tree on each modification and look where
> > > it goes wrong.
> > >
> > > That said, I did print my fair share of (augmented) RB trees while
> > > playing with scheduler patches and I can't remember it ever having
> > > messed up like that.
> > He's using 2.6.35-rc2+, without your "rbtree: Undo augmented trees 
> > performance damage" patch ;-)
> 
> I applied it manually (commit 2463eb8b3093995e09a0d41b3d78ee0cf5fb4249 from -tip)
> to 2.6.35-rc3 and it fixed both acpi's and nouveau's "invalid memtype" messages.
> Thanks.

Oh neat, so it actually fixes a bug in the previous augmented rb-tree
implementation?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/