Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932894Ab0FUQrm (ORCPT ); Mon, 21 Jun 2010 12:47:42 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:57329 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932148Ab0FUQrk (ORCPT ); Mon, 21 Jun 2010 12:47:40 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=AG0RtIQgOkdP/N/aMYdf59735IY/w95Hg98CyxXO2urvLJDCZkpJxnUFhRDHdenNWb LIQNPfHzimLFoikOXKhP9+d54YTTMwbNKyZBq/6bPdM5seQGFmnWEW+GqLzCHZmW3jg/ fcvGpz5OsIk5JTnaqzmxoF7mIGjmEh8Pcvx7A= Date: Mon, 21 Jun 2010 20:47:32 +0400 From: Anton Vorontsov To: Mike Frysinger Cc: Barry Song <21cnbao@gmail.com>, "Song, Barry" , David Brownell , Artem Bityutskiy , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, Andrew Morton Subject: Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code Message-ID: <20100621164732.GA2725@oksana.dev.rtsoft.ru> References: <20100618133212.GA5276@oksana.dev.rtsoft.ru> <0F1B54C89D5F954D8535DB252AF412FA065551D8@chinexm1.ad.analog.com> <20100621071551.GA16109@oksana.dev.rtsoft.ru> <20100621073909.GA20674@oksana.dev.rtsoft.ru> <20100621112049.GA9273@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2598 Lines: 54 On Mon, Jun 21, 2010 at 12:34:05PM -0400, Mike Frysinger wrote: > On Mon, Jun 21, 2010 at 07:20, Anton Vorontsov wrote: > > You can't easily change OF. It's like "let's change ACPI tables > > or BIOS in these PCs". Doable, but involves things like reflashing. > > And we usually have to support old BIOSes as well. > > > > OTOH, I see (git grep m25p arch/powerpc/boot/dts/) that in > > mainline kernel only MPC8569 board has a correct m25p > > node, and it is STMicro variant (it is JEDEC capable). > > > > As we don't really have to support out of tree code, I'd > > just go with this patch, assuming that we have to change > > device tree for boards with non-JEDEC flashes. It's > > effectively the same thing as platform data flag, except > > that it works automatically for OF platforms. > > > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > > index 81e49a9..a610ca9 100644 > > --- a/drivers/mtd/devices/m25p80.c > > +++ b/drivers/mtd/devices/m25p80.c > > @@ -680,6 +680,16 @@ static const struct spi_device_id m25p_ids[] = { > >        { "m25p64",  INFO(0x202017,  0,  64 * 1024, 128, 0) }, > >        { "m25p128", INFO(0x202018,  0, 256 * 1024,  64, 0) }, > > > > +       { "m25p05-nonjedec",  INFO(0, 0,  32 * 1024,   2, 0) }, > > +       { "m25p10-nonjedec",  INFO(0, 0,  32 * 1024,   4, 0) }, > > +       { "m25p20-nonjedec",  INFO(0, 0,  64 * 1024,   4, 0) }, > > +       { "m25p40-nonjedec",  INFO(0, 0,  64 * 1024,   8, 0) }, > > +       { "m25p80-nonjedec",  INFO(0, 0,  64 * 1024,  16, 0) }, > > +       { "m25p16-nonjedec",  INFO(0, 0,  64 * 1024,  32, 0) }, > > +       { "m25p32-nonjedec",  INFO(0, 0,  64 * 1024,  64, 0) }, > > +       { "m25p64-nonjedec",  INFO(0, 0,  64 * 1024, 128, 0) }, > > +       { "m25p128-nonjedec", INFO(0, 0, 256 * 1024,  64, 0) }, > > + > > are you picking the m25p because its flash geometry matches whatever > you're using, or because you have some weird variant of the m25p that > has JEDEC commands removed ? The latter. It's Numonyx M25Pxx flashes, see http://www.numonyx.com/Documents/Datasheets/M25P80.pdf The RDID instruction is available only for parts made with 110 nm Technology identified with Process letter '4'. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/