Date: Mon, 21 Jun 2010 13:00:08 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Don Zickus <dzickus@redhat.com>
Cc: Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org,
       Randy Dunlap <randy.dunlap@oracle.com>, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] Add TAINT_HARDWARE_UNSUPPORTED flag
Message-Id: <20100621130008.d3dc01a8.akpm@linux-foundation.org>
In-Reply-To: <20100621194559.GI3217@redhat.com>
References: <20100617134654.22523.39845.sendpatchset@prarit.bos.redhat.com>
	<20100617091322.b7d21473.randy.dunlap@oracle.com>
	<4C1A7D61.8010900@redhat.com>
	<20100621122145.76ebd7ac.akpm@linux-foundation.org>
	<20100621194559.GI3217@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2069
Lines: 60

On Mon, 21 Jun 2010 15:45:59 -0400
Don Zickus <dzickus@redhat.com> wrote:

> On Mon, Jun 21, 2010 at 12:21:45PM -0700, Andrew Morton wrote:
> > > @@ -243,6 +245,9 @@ void add_taint(unsigned flag)
> > >  	 */
> > >  	if (flag != TAINT_CRAP && flag != TAINT_WARN && __debug_locks_off())
> > >  		printk(KERN_WARNING "Disabling lock debugging due to kernel taint\n");
> > > +	if (flag == TAINT_HARDWARE_UNSUPPORTED)
> > > +		printk(KERN_CRIT
> > > +		       "WARNING: This system's hardware is unsupported.\n");
> > >  
> > >  	set_bit(flag, &tainted_mask);
> > >  }
> > 
> > That's pretty user-hostile.  What are they to do - throw the entire
> > computer away because it has the wrong type of mouse?
> > 
> > How about
> > 
> > void add_hardware_unsupported_taint(const char *hardware)
> > {
> > 	printk(KERN_CRIT
> > 	       "Hardware device %s is unsupported by this kernel's vendor\n",
> > 		hardware);
> > 	add_taint(TAINT_HARDWARE_UNSUPPORTED);
> > }
> > 
> > and
> > 
> > /*
> >  * Don't call add_taint(TAINT_HARDWARE_UNSUPPORTED) directly - use
> >  * add_hardware_unsupported_taint()
> >  */
> > #define TAINT_HARDWARE_UNSUPPORTED	12
> 
> Internally here that is how we planned on using the flag.  We weren't sure
> if upstream would accept that piece or not, so we started with the flag
> for now to at least reserve the bit.
> 
> But I can see your point about the other printk being a little
> user-hostile if someone forgot to call the wrapper function.
> 
> I can respin with the wrapper function (Prarit is on vacation)

Not telling the user _which_ hardware is causing the problem is daft.

> or go with
> Alan's idea of just reserving the upper few bits.

um.  Given that the vendor needs to patch the individual drivers to
indicate ther unsupported status, why not just patch in the taint
changes as well?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/