DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=Wyq8C2iaDMdUxqf3TxVqtmkCCRiy4EAaBa/uzb2I+2eiKYlsDwgQ8erWx/OEkB8UGTUo8NUpgdJrhxDcB/0n3Czrgg/LhY1zw1kQJN5VFgNKNFCcfCWqgpRoqRMLSHNMPMAJnSYYoCkI6AI/RR2HMeTeKxGBnpEERCv5GJGoQT0=;
Message-ID: <294115.59939.qm@web180308.mail.gq1.yahoo.com>
Date: Wed, 23 Jun 2010 06:39:09 -0700 (PDT)
From: David Brownell <david-b@pacbell.net>
Subject: Re: gpiolib and sleeping gpios
To: Jani Nikula <ext-jani.1.nikula@nokia.com>
Cc: Ryan Mallon <ryan@bluewatersys.com>,
       linux kernel <linux-kernel@vger.kernel.org>,
       linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       David Brownell <dbrownell@users.sourceforge.net>,
       "gregkh@suse.de" <gregkh@suse.de>,
       =?iso-8859-1?Q?Uwe_Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
In-Reply-To: <alpine.DEB.2.00.1006231601310.7850@wnav-qrfxgbc>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 525
Lines: 20


--- On Wed, 6/23/10, Jani Nikula <ext-jani.1.nikula@nokia.com> wrote:

> -??? WARN_ON(extra_checks &&
> chip->can_sleep);
> +??? might_sleep_if(chip->can_sleep);

 That looks like the right track.  For
those cases the "extra_checks" should
not be optional ... thanks.

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/