Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752502Ab0FWQzF (ORCPT ); Wed, 23 Jun 2010 12:55:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794Ab0FWQzB (ORCPT ); Wed, 23 Jun 2010 12:55:01 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1277220198-3522-1-git-send-email-sjayaraman@suse.de> References: <1277220198-3522-1-git-send-email-sjayaraman@suse.de> To: Suresh Jayaraman Cc: dhowells@redhat.com, Steve French , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 04/10] cifs: define server-level cache index objects and register them with FS-Cache Date: Wed, 23 Jun 2010 17:54:52 +0100 Message-ID: <9658.1277312092@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 19 Suresh Jayaraman wrote: > Define server-level cache index objects (as managed by TCP_ServerInfo > structs). Each server object is created in the CIFS top-level index object > and is itself an index into which superblock-level objects are inserted. > > Currently, the server objects are keyed by hostname. > > Signed-off-by: Suresh Jayaraman Looks reasonable, apart from the index key. I agree with Jeff that you probably want {address,port,family} rather than a hostname. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/