Date: Thu, 24 Jun 2010 08:32:18 -0700
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-fsdevel@vger.kernel.org,
       linux-kernel@vger.kernel.org, John Stultz <johnstul@us.ibm.com>,
       Frank Mayhar <fmayhar@google.com>
Subject: Re: [patch 24/52] fs: dcache reduce d_parent locking
Message-ID: <20100624153218.GC2373@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <20100624030212.676457061@suse.de>
 <20100624030729.395195069@suse.de>
 <1277369062.1875.928.camel@laptop>
 <20100624150706.GF10441@laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100624150706.GF10441@laptop>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1817
Lines: 44

On Fri, Jun 25, 2010 at 01:07:06AM +1000, Nick Piggin wrote:
> On Thu, Jun 24, 2010 at 10:44:22AM +0200, Peter Zijlstra wrote:
> > On Thu, 2010-06-24 at 13:02 +1000, npiggin@suse.de wrote:
> > > Use RCU property of dcache to simplify locking in some places where we
> > > take d_parent and d_lock.
> > > 
> > > Comment: don't need rcu_deref because we take the spinlock and recheck it.
> > 
> > But does the LOCK barrier imply a DATA DEPENDENCY barrier? (It does on
> > x86, and the compiler barrier implied by spin_lock() suffices to replace
> > ACCESS_ONCE()).
> 
> Well the dependency we care about is from loading the parent pointer
> to acquiring its spinlock. But we can't possibly have stale data given
> to the spin lock operation itself because it is a RMW.

As long as you check for the structure being valid after acquiring the
lock, I agree.  Otherwise, I would be concerned about the following
sequence of events:

1.	CPU 0 picks up a pointer to a given data element.

2.	CPU 1 removes this element from the list, drops any locks that
	it might have, and starts waiting for a grace period to
	elapse.

3.	CPU 0 acquires the lock, does some operation that would
	be appropriate had the element not been removed, then
	releases the lock.

4.	After the grace period, CPU 1 frees the element, negating
	CPU 0's hard work.

The usual approach is to have a "deleted" flag or some such in the
element that CPU 0 would set when removing the element and that CPU 1
would check after acquiring the lock.  Which you might well already
be doing!  ;-)

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/