Message-ID: <4C238D09.5050200@codeaurora.org>
Date: Thu, 24 Jun 2010 09:51:21 -0700
From: Patrick Pannuto <ppannuto@codeaurora.org>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: Andi Kleen <andi@firstfloor.org>
CC: linux-kernel@vger.kernel.org, sboyd@codeaurora.org, tglx@linutronix.de,
       mingo@elte.hu, heiko.carstens@de.ibm.com, eranian@google.com,
       schwidefsky@de.ibm.com
Subject: Re: [RFC] [PATCH] timer: Added usleep[_range][_interruptable] timer
References: <4C225EED.5040600@codeaurora.org> <871vbwafwu.fsf@basil.nowhere.org>
In-Reply-To: <871vbwafwu.fsf@basil.nowhere.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 947
Lines: 27

Andi Kleen wrote:
> Patrick Pannuto <ppannuto@codeaurora.org> writes:
> 
> Overall it seems like a good improvement.
> 
>> +
>> +static inline void usleep(unsigned long usecs)
>> +{
>> +	usleep_range(usecs, usecs);
>> +}
>> +
>> +static inline unsigned long usleep_interruptible(unsigned long usecs)
> 
> Is the interruptible case even needed?  I assume most drivers won't
> bother with that and not being interruptible for a few usecs is not a
> big issue.

Honestly, I don't think so, but I was mirroring the msleep API when
I wrote it so I included it for completeness.  I can't think of a use
case where it is necessary / useful. I will remove it unless anyone
can think of an application for it?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/