Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756228Ab0FYOIe (ORCPT ); Fri, 25 Jun 2010 10:08:34 -0400 Received: from nlpi129.sbcis.sbc.com ([207.115.36.143]:50900 "EHLO nlpi129.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755010Ab0FYOIc (ORCPT ); Fri, 25 Jun 2010 10:08:32 -0400 Date: Fri, 25 Jun 2010 09:07:39 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: KOSAKI Motohiro cc: LKML , linux-mm , Andrew Morton , Mel Gorman , Rik van Riel , Minchan Kim , Johannes Weiner Subject: Re: [PATCH 1/2] vmscan: shrink_slab() require number of lru_pages, not page order In-Reply-To: <20100625201915.8067.A69D9226@jp.fujitsu.com> Message-ID: References: <20100625201915.8067.A69D9226@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 22 On Fri, 25 Jun 2010, KOSAKI Motohiro wrote: > Fix simple argument error. Usually 'order' is very small value than > lru_pages. then it can makes unnecessary icache dropping. This is going to reduce the delta that is added to shrinker->nr significantly thereby increasing the number of times that shrink_slab() is called. What does the "lru_pages" parameter do in shrink_slab()? Looks like its only role is as a divison factor in a complex calculation of pages to be scanned. do_try_to_free_pages passes 0 as "lru_pages" to shrink_slab() when trying to do cgroup lru scans. Why is that? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/