Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755777Ab0F0Qoq (ORCPT ); Sun, 27 Jun 2010 12:44:46 -0400 Received: from borg.medozas.de ([188.40.89.202]:51264 "EHLO borg.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755552Ab0F0Qoo (ORCPT ); Sun, 27 Jun 2010 12:44:44 -0400 Date: Sun, 27 Jun 2010 18:44:42 +0200 (CEST) From: Jan Engelhardt To: Jan Kara cc: Linus Torvalds , Jens Axboe , Linux Kernel , stable@kernel.org, gregkh@suse.de Subject: Re: [PATCH] writeback: Fix broken sync writeback In-Reply-To: Message-ID: References: <20100212091609.GB1025@kernel.dk> <20100215144938.GD3434@quack.suse.cz> User-Agent: Alpine 2.01 (LSU 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 28 Hi Jan Kara, On Monday 2010-02-15 16:41, Jan Engelhardt wrote: >On Monday 2010-02-15 15:49, Jan Kara wrote: >>On Sat 13-02-10 13:58:19, Jan Engelhardt wrote: >>> >> >>> >> This fixes it by using the passed in page writeback count, instead of >>> >> doing MAX_WRITEBACK_PAGES batches, which gets us much better performance >>> >> (Jan reports it's up from ~400KB/sec to 10MB/sec) and makes sync(1) >>> >> finish properly even when new pages are being dirted. >>> > >>> >This seems broken. >>> >>> It seems so. Jens, Jan Kara, your patch does not entirely fix this. >>> While there is no sync/fsync to be seen in these traces, I can >>> tell there's a livelock, without Dirty decreasing at all. What ultimately became of the discussion and/or the patch? Your original ad-hoc patch certainly still does its job; had no need to reboot in 86 days and still counting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/