Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595Ab0F1FQV (ORCPT ); Mon, 28 Jun 2010 01:16:21 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:44382 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583Ab0F1FQS (ORCPT ); Mon, 28 Jun 2010 01:16:18 -0400 Date: Mon, 28 Jun 2010 07:16:06 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Eric Miao , Sascha Hauer Cc: Greg KH , Randy Dunlap , Dmitry Torokhov , Anisse Astier , Greg Kroah-Hartman , Magnus Damm , "Rafael J. Wysocki" , Paul Mundt , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/2 v2] Driver core: reduce duplicated code Message-ID: <20100628051606.GA16445@pengutronix.de> References: <20100618073950.GA12822@pengutronix.de> <1277129511-2732-1-git-send-email-u.kleine-koenig@pengutronix.de> <20100621213846.GB25511@kroah.com> <20100622052314.GA17128@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1727 Lines: 49 Hi Eric, On Mon, Jun 28, 2010 at 12:55:45PM +0800, Eric Miao wrote: > I suggest you to have a look into arch/arm/mach-mmp/devices.c and > arch/arm/mach-mmp/pxa{168,910}.c as well as > arch/arm/mach-mmp/include/mach/pxa{168,910}.h, maybe we can find > some common practice. I think I like this approach in general, I already thought about not passing all parameters as function/macro arguments, too. But maybe this becomes too excessive for imx as I would need too many of these device desc for the different imx variants?! Anyhow a few things I thought when looking in the files you suggested: - Why not use an array for all uart devdescs, maybe the code for pxa168_add_uart could become a bit smaller then?: extern struct pxa_device_desc pxa168_device_uart[2]; ... static inline int pxa168_add_uart(int id) { struct pxa_device_desc *d = pxa168_device_uart + id; if (id < 0 || id > 2) return -EINVAL; return pxa_register_device(d, NULL, 0); } (Ditto for the other types obviously.) - shouldn't all these pxa_device_descs and pxa168_add_$device functions be __initdata and __init? - pxa_register_device is better than my add_resndata function in (at least) one aspect as it sets coherent_dma_mask, too. This is something I missed when trying to add mxc-mmc (IIRC) devices. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/