Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754804Ab0F1N0n (ORCPT ); Mon, 28 Jun 2010 09:26:43 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:50378 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395Ab0F1N0k (ORCPT ); Mon, 28 Jun 2010 09:26:40 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=unLSTA66f0o7/yySerUMXh0yxaNHp3QYEAxraIHGpZl8RilfQ2pKuJzkffF/3VITFN wPxeOgmum7I+cP6hI9Iiwr0BmQ+4Wusq8c00+hEA0UeBtPp4pBgl0Rqd/BOANfz+kTkg 41uNLsAUb1srOEqvZ9ZUFKlGdw9Q8d0HFiPy8= Date: Mon, 28 Jun 2010 15:24:53 +0200 From: Dan Carpenter To: Kulikov Vasiliy Cc: trivial@kernel.org, Kernel Janitors , Greg Kroah-Hartman , Henk de Groot , Joe Perches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/16] trivial: use ARRAY_SIZE Message-ID: <20100628132453.GK19184@bicker> Mail-Followup-To: Dan Carpenter , Kulikov Vasiliy , trivial@kernel.org, Kernel Janitors , Greg Kroah-Hartman , Henk de Groot , Joe Perches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1277726143-24899-1-git-send-email-segooon@gmail.com> <20100628125224.GJ19184@bicker> <20100628131511.GA26416@shinshilla> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100628131511.GA26416@shinshilla> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1932 Lines: 49 On Mon, Jun 28, 2010 at 05:15:11PM +0400, Kulikov Vasiliy wrote: > On Mon, Jun 28, 2010 at 14:52 +0200, Dan Carpenter wrote: > > On Mon, Jun 28, 2010 at 03:55:41PM +0400, Kulikov Vasiliy wrote: > > > Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x). > > > > > > Signed-off-by: Kulikov Vasiliy > > > --- > > > drivers/staging/wlags49_h2/hcf.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/staging/wlags49_h2/hcf.c b/drivers/staging/wlags49_h2/hcf.c > > > index 390628c..c4fe0ec 100644 > > > --- a/drivers/staging/wlags49_h2/hcf.c > > > +++ b/drivers/staging/wlags49_h2/hcf.c > > > @@ -502,7 +502,7 @@ HCF_STATIC hcf_16* BASED xxxx[ ] = { > > > #endif // MSF_COMPONENT_ID > > > NULL //endsentinel > > > }; > > > -#define xxxx_PRI_IDENTITY_OFFSET (sizeof(xxxx)/sizeof(xxxx[0]) - 3) > > > +#define xxxx_PRI_IDENTITY_OFFSET (ARRAY_SIZE(xxxx) - 3) > > > > > > > I would say the more critical problem with this macro is that it doesn't > > work unless you name all your arrays "xxxx[]" so it encourages sub par > > variable names. > > > > You could do: > > #define PRI_IDENTITY_OFFSET(x) (ARRAY_SIZE(x) - 3) > > Look at the patch: > > > > @@ -502,7 +502,7 @@ HCF_STATIC hcf_16* BASED xxxx[ ] = { > There is an array called 'xxxx' and macro xxxx_PRI_IDENTITY_OFFSET is defined > after array definition. This magic macroconstant is used in the code to get > elements of xxxx. Right right. But xxxx is a stupid name for a variable. I wanted to poke my eyes out with a fork. Not your fault obviously. Your patch doesn't make it worse so I'm fine with it as far as it goes... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/