Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 19 Jun 2002 05:18:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 19 Jun 2002 05:18:37 -0400 Received: from hermes.fachschaften.tu-muenchen.de ([129.187.176.19]:59622 "HELO hermes.fachschaften.tu-muenchen.de") by vger.kernel.org with SMTP id ; Wed, 19 Jun 2002 05:18:36 -0400 Date: Wed, 19 Jun 2002 11:18:34 +0200 (CEST) From: Adrian Bunk X-X-Sender: bunk@mimas.fachschaften.tu-muenchen.de To: Manik Raina cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH]: (off 2.5.22) replacing __builtin_expect with unlikely in Alpha headers In-Reply-To: <3D104A50.24C00206@cisco.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 34 On Wed, 19 Jun 2002, Manik Raina wrote: > > This fix should remove __builtin_expect () and replace it with > unlikely () in include/asm-alpha/rwsem.h > This should be cool since rwsem.h already includes > include/linux/compiler.h > > Files changed : > > include/asm-alpha/rwsem.h The following part of your patch is obviously a typo: - if (__builtin_expect(count, 0)) + if (unlikely(count, 0)) ^^^ cu Adrian -- You only think this is a free country. Like the US the UK spends a lot of time explaining its a free country because its a police state. Alan Cox - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/