Date: Tue, 29 Jun 2010 14:14:57 +0200
From: Michal Marek <mmarek@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Cong Wang <amwang@redhat.com>, linux-kernel@vger.kernel.org,
       linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/2] Makefile: fix missing dash when using make
 LOCALVERSION=xxx
Message-ID: <20100629121457.GB13335@sepie.suse.cz>
References: <20100628030507.5187.95903.sendpatchset@localhost.localdomain>
 <alpine.DEB.2.00.1006280207580.28072@chino.kir.corp.google.com>
 <4C286A8F.9080508@redhat.com>
 <alpine.DEB.2.00.1006281145590.25490@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1006281145590.25490@chino.kir.corp.google.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1039
Lines: 26

On Mon, Jun 28, 2010 at 11:46:37AM -0700, David Rientjes wrote:
> On Mon, 28 Jun 2010, Cong Wang wrote:
> 
> > But in your patch description, you said:
> > 
> >     Without CONFIG_LOCALVERSION_AUTO, "make" results in v2.6.32-rc4+
> >     unless the repository is at the Linux v2.6.32-rc4 commit (in which
> >     case the version would be v2.6.32-rc4).  If "make LOCALVERSION=kbuild"
> >     were used, it results in v2.6.32-rc4-kbuild.
> > 
> > So, shouldn't that be "make LOCALVERSION=-kbuild"?
> > 
> 
> Yup, that's what it should have said.  That doesn't mean that we need to 
> change the long-standing behavior of LOCALVERSION= to add an implied `-', 
> though.

Agreed, we should not enforce any new policy here. Someone might wish to
use underscores as separators for instance.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/