DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=OjfSy7lC2tS0CnpK7uSCFiam/HA/QimJVUzVehuzL+oS20e/Fqe5q5oE6ixxAjSbJa5yGyhV4y5w98aJ3cN1yzQXy0o5MBQm7aMbxtHaeQ+nET8w9PnzD4VM19tbGe9HmP5aw6P1fknPX8mGMTNICeSvgnWe4h6muzq+cXopOJ0=;
Message-ID: <326628.87627.qm@web180310.mail.gq1.yahoo.com>
Date: Tue, 29 Jun 2010 07:08:49 -0700 (PDT)
From: David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH 5/6] usb/gadget: Do not take BKL for gadget->ops->ioctl
To: Greg KH <gregkh@suse.de>, Arnd Bergmann <arnd@arndb.de>,
       =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= <m.nazarewicz@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
       Frederic Weisbecker <fweisbec@gmail.com>,
       John Kacur <jkacur@redhat.com>, Andi Kleen <andi@firstfloor.org>,
       David Brownell <dbrownell@users.sourceforge.net>
In-Reply-To: <op.veh043ad7p4s8u@pikus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 761
Lines: 24


> Date: Friday, June 18, 2010, 6:59 AM
> On Tue, 01 Jun 2010 23:04:44 +0200,
> Arnd Bergmann <arnd@arndb.de>
> wrote:
> > There is no gadget driver in the tree that
> > actually implements the ioctl operation, so
> > obviously it is not necessary to hold the
> > BKL around the call.

The original gadgetfs code used it as a
passthrough to controller-specific ops, as
I recall.  Not much used, right.

And yes, I suspect someone just threw
some BKL stuff here without actually
analysing whether it was necessary.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/