Date: Tue, 29 Jun 2010 18:28:59 +0200
From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= <bonbons@linux-vserver.org>
To: Alexander Clouter <alex@digriz.org.uk>, Dmitry Torokhov <dtor@vmware.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] VMware balloon: force compiling as a module
Message-ID: <20100629182859.5acd5be7@neptune.home>
In-Reply-To: <vcnof7-b9p.ln1@chipmunk.wormnet.eu>
References: <20100628230035.GA18971@dtor-ws.eng.vmware.com>
	<vcnof7-b9p.ln1@chipmunk.wormnet.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1312
Lines: 31

On Tue, 29 June 2010 Alexander Clouter <alex@digriz.org.uk> wrote:
> Dmitry Torokhov <dtor@vmware.com> wrote:
> >
> > VMware Tools installer requires the upstream driver to be compiled
> > as a module in order to detect its presence and avoid installing
> > our own version on top of it. To avoid surprises with 2 versions
> > of the driver being installed and fighting with each other, let's
> > force the driver to be compiled as a module unless user selects
> > CONFIG_EMBEDDED.
> >
> *barf*
> 
> This surely is a problem in the installer and not the kernel?  Can you 
> not nosey around in /sys/class/misc or where-ever your driver appears?  
> If it does not, then I would probably suggest a patch to your balloon 
> driver that dumps some details in there, including module version 
> information.
> 
> Eugh.

In addition, the installer may check under /sys/module/ for it (as for
any/most code that can be built as a module), even for built-in code.
(if balloon driver does not show up there when built-in it would be
better to get it to show up there)

Bruno
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/