Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986Ab0F3Bb5 (ORCPT ); Tue, 29 Jun 2010 21:31:57 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:17902 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370Ab0F3Bbz (ORCPT ); Tue, 29 Jun 2010 21:31:55 -0400 Date: Tue, 29 Jun 2010 18:30:53 -0700 From: Joel Becker To: Linus Torvalds , Dave Chinner , Linux Kernel , ocfs2-devel@oss.oracle.com, Tao Ma , Dave Chinner , Christoph Hellwig , Mark Fasheh Subject: Re: [Ocfs2-devel] [PATCH] Revert "writeback: limit write_cache_pages integrity scanning to current EOF" Message-ID: <20100630013053.GK4150@mail.oracle.com> Mail-Followup-To: Linus Torvalds , Dave Chinner , Linux Kernel , ocfs2-devel@oss.oracle.com, Tao Ma , Dave Chinner , Christoph Hellwig , Mark Fasheh References: <20100628173529.GA10573@mail.oracle.com> <20100629002421.GY6590@dastard> <20100629005403.GC24343@mail.oracle.com> <20100629015822.GD24343@mail.oracle.com> <20100629081611.GB4150@mail.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100629081611.GB4150@mail.oracle.com> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.20 (2009-06-14) X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4C2A9E69.0062:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 35 On Tue, Jun 29, 2010 at 01:16:11AM -0700, Joel Becker wrote: > On Mon, Jun 28, 2010 at 07:20:33PM -0700, Linus Torvalds wrote: > > Your call, I guess. If any ocfs2 fix looks scary, and you'd prefer to > > have an -rc4 (in a few days - not today) with just the revert, I'm ok > > with that. Even if it's only a "at least no worse than 2.6.34" > > situation rather than a real fix. > > If -rc4 isn't coming for a couple of days, can we hold off on > the decision until we get a chance to think about a paper-over solution > for it? Then we can avoid the revert. Linus, I'm going to withdraw the revert request for now. Our proposed paper-over solution is too big, and we're just going to focus on the actual fix. This will be for .35. Yes, .35-rc will have a BUG_ON with refcount trees until we get the fix in, but I'd rather avoid the churn when the final .35 should have Dave's patch and our fix. Joel -- "The first thing we do, let's kill all the lawyers." -Henry VI, IV:ii Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/