Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044Ab0GAEGG (ORCPT ); Thu, 1 Jul 2010 00:06:06 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:3823 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513Ab0GAEGE (ORCPT ); Thu, 1 Jul 2010 00:06:04 -0400 Message-ID: <000001cb18d2$b7d576d0$66f8800a@maildom.okisemi.com> From: "Masayuki Ohtake" To: "Randy Dunlap" Cc: "Andy Isaacson" , "Andrew Morton" , "Arnd Bergmann" , "Wang, Yong Y" , , , , "Alan Cox" , "LKML" References: <4C204B0D.2030201@dsn.okisemi.com><4C2AF782.1070802@dsn.okisemi.com> <20100630110517.d8f3b875.randy.dunlap@oracle.com> Subject: Re: [PATCH] Packet hub driver of Topcliff PCH Date: Thu, 1 Jul 2010 11:52:09 +0900 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1983 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1983 X-Hosting-Pf: 0 X-NAI-Spam-Score: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3398 Lines: 102 Hi Randy > It's listed in the MAINTAINERS file. Please use that. I will add Arnd's e-mail address. > Maybe lose some acromyns? Overall, this help text should be about > *what* PCH_PHUB is, not *how* it accomplishes its work. > If you want to document *how* it works, put that into the source code > or Documentation/ somewhere. I will rewrite my help text. Thanks, Ohtake ----- Original Message ----- From: "Randy Dunlap" To: "Masayuki Ohtak" Cc: "Andy Isaacson" ; "Andrew Morton" ; "Arnd Bergmann" ; "Wang, Yong Y" ; ; ; ; "Alan Cox" ; "LKML" Sent: Thursday, July 01, 2010 3:05 AM Subject: Re: [PATCH] Packet hub driver of Topcliff PCH > On Wed, 30 Jun 2010 16:51:30 +0900 Masayuki Ohtak wrote: > > > Hi Andy and Andrew > > > > I have modified for your comments. > > Please confirm below. > > > > --- > > > > > > Packet hub driver of Topcliff PCH > > > > Topcliff PCH is the platform controller hub that is going to be used in > > Intel’s upcoming general embedded platform. All IO peripherals in > > Topcliff PCH are actually devices sitting on AMBA bus. Packet hub is > > a special converter device in Topcliff PCH that translate AMBA transactions > > to PCI Express transactions and vice versa. Thus packet hub helps present > > all IO peripherals in Topcliff PCH as PCIE devices to IA system. > > Topcliff PCH have MAC address and Option ROM data. > > These data are in SROM which is connected to PCIE bus. > > Packet hub driver of Topcliff PCH can access MAC address and Option ROM data in > > SROM. > > > > Signed-off-by: Masayuki Ohtake > > Acked-by: Arnd > > It's listed in the MAINTAINERS file. Please use that. > > > > > > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > > index e023682..1851e97 100644 > > --- a/drivers/char/Kconfig > > +++ b/drivers/char/Kconfig > > @@ -4,6 +4,16 @@ > > > > menu "Character devices" > > > > +config PCH_PHUB > > + tristate "PCH PHUB" > > + depends on PCI > > + help > > + Topcliff is a IOH for x86 embedded processor. This IOH is quite > > is an IOH for x86 embedded processors. > > > + different with the traditional IOH. Topcliff is a kind of ARM-based > > from > > > + processor and connected with PCIe bus (from x86 processor). > > + PHUB work as a gateway transform the PCIe transaction into the AMBA > > works as a gateway to transform > > > + transaction, and vise verse, and have several transform windows also. > > vice versa, and has several > > > > Maybe lose some acromyns? Overall, this help text should be about > *what* PCH_PHUB is, not *how* it accomplishes its work. > If you want to document *how* it works, put that into the source code > or Documentation/ somewhere. > > > --- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/