Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755891Ab0GAM4z (ORCPT ); Thu, 1 Jul 2010 08:56:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54317 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753789Ab0GAM4x (ORCPT ); Thu, 1 Jul 2010 08:56:53 -0400 Date: Thu, 1 Jul 2010 15:50:38 +0300 From: "Michael S. Tsirkin" To: Peter Zijlstra Cc: Ingo Molnar , Sridhar Samudrala , Tejun Heo , Oleg Nesterov , netdev , lkml , "kvm@vger.kernel.org" , Andrew Morton , Dmitri Vorobiev , Jiri Kosina , Thomas Gleixner , Andi Kleen Subject: Re: [PATCH repost] sched: export sched_set/getaffinity to modules Message-ID: <20100701125038.GA32223@redhat.com> References: <20100530112925.GB27611@redhat.com> <4C02C99D.9070204@kernel.org> <20100624081135.GA937@redhat.com> <1277419551.27868.27.camel@w-sridhar.beaverton.ibm.com> <20100625101022.GA16321@redhat.com> <20100701110708.GA27368@redhat.com> <1277983179.1917.10.camel@laptop> <1277984603.1917.15.camel@laptop> <20100701115507.GA31333@redhat.com> <1277987563.1917.28.camel@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1277987563.1917.28.camel@laptop> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 37 On Thu, Jul 01, 2010 at 02:32:43PM +0200, Peter Zijlstra wrote: > On Thu, 2010-07-01 at 14:55 +0300, Michael S. Tsirkin wrote: > > > > - why can't it set the kernel thread's affinity too? > > > > It can. However: the threads are started internally by the driver > > when qemu does an ioctl. What we want to do is give it a sensible > > default affinity. management tool can later tweak it if it wants to. > > So have that ioctl return the tid of that new fancy thread and then set > its affinity, stuff it in cgroup, whatever you fancy. > > > > - what happens if someone changes the tasks' affinity? > > > > We would normally create a cgroup including all internal > > tasks, making it easy to find and change affinity for > > them all if necessary. > > And to stuff them in a cgroup you also need the tid, at which point it > might as well set the affinity from userspace, right? We also put it in a cgroup transparently. I think that it's actually important to do it on thread creation: if we don't, malicious userspace can create large amount of work exceeding the cgroup limits. And the same applies so the affinity, right? If the qemu process is limited to a set of CPUs, isn't it important to make the kernel thread that does work our behalf limited to the same set of CPUs? -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/