Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758266Ab0GAUAk (ORCPT ); Thu, 1 Jul 2010 16:00:40 -0400 Received: from mail-px0-f174.google.com ([209.85.212.174]:64084 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757879Ab0GAUAi (ORCPT ); Thu, 1 Jul 2010 16:00:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=X3TuFodYWbial3HHgKs1f2AUx1KKXHWTWRpLhRl7PjFtdXpoZOQBuzvC98UUd20OpQ sys23NaMR+LqIjTi6dSDfg6dTf+WkMMlIoxsR0dviSrVbwF058AG31GfaQC2kAUi1Rl7 L0E9MALfbekppdHWkciWldxN/2gie5m6VW2fM= Message-ID: <4C2CF400.20507@gmail.com> Date: Thu, 01 Jul 2010 13:01:04 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100615 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: David Howells CC: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, lenb@kernel.org Subject: Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used References: <4C2B9F49.8090304@gmail.com> <4C2A6B6C.1000306@gmail.com> <4C29674C.9070503@gmail.com> <4C28E14D.5050701@gmail.com> <1277621246-10960-4-git-send-email-justinmattock@gmail.com> <1277621246-10960-1-git-send-email-justinmattock@gmail.com> <7214.1277729293@redhat.com> <8066.1277750854@redhat.com> <22319.1277826461@redhat.com> <25800.1277889215@redhat.com> <16513.1277976706@redhat.com> In-Reply-To: <16513.1277976706@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2589 Lines: 88 > Not sure it's worth going that far. You could reduce it still further: > > if (fn || pn) > dev_warn(&acpi_dev->dev, > "Failed to create link(s) to %s %s:" > " %d\n", > dev_driver_string(dev), dev_name(dev), > fn ?: pn); > > Is it that important to know which failed to be created, or that both failed > to be created? > > David > I like this.. fn ?: pn (will this give us the results from the above question? _both failed to be created_) a bit confused with the whole: "?:" though *condition ? value if true : value if false* (what if both are true what if both are false or does it matter?) here is the patch itself with the change: Fix a warning message generated by gcc: Im getting a warning message when building with gcc 4.6.0 CC drivers/acpi/glue.o drivers/acpi/glue.c: In function 'acpi_bind_one': drivers/acpi/glue.c:163:7: warning: variable 'ret' set but not used Signed-off-by: Justin P. Mattock Signed-off-by: David Howells --- drivers/acpi/glue.c | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 4af6301..23b16e6 100644 --- a/drivers/acpi/glue.c +++ b/drivers/acpi/glue.c @@ -145,6 +145,7 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle) { struct acpi_device *acpi_dev; acpi_status status; + int fn, pn; if (dev->archdata.acpi_handle) { dev_warn(dev, "Drivers changed 'acpi_handle'\n"); @@ -160,12 +161,19 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle) status = acpi_bus_get_device(handle, &acpi_dev); if (!ACPI_FAILURE(status)) { - int ret; - ret = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj, + fn = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj, "firmware_node"); - ret = sysfs_create_link(&acpi_dev->dev.kobj, &dev->kobj, + pn = sysfs_create_link(&acpi_dev->dev.kobj, &dev->kobj, "physical_node"); + if (fn || pn) { + dev_warn(&acpi_dev->dev, + "Failed to create link(s) to %s %s:" + " %d\n", + dev_driver_string(dev), dev_name(dev), + fn ?: pn); + return AE_ERROR; + } if (acpi_dev->wakeup.flags.valid) { device_set_wakeup_capable(dev, true); device_set_wakeup_enable(dev, -- 1.7.1.rc1.21.gf3bd6 Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/