Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757186Ab0GBG31 (ORCPT ); Fri, 2 Jul 2010 02:29:27 -0400 Received: from shutemov.name ([188.40.19.243]:58678 "EHLO shutemov.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755977Ab0GBG30 (ORCPT ); Fri, 2 Jul 2010 02:29:26 -0400 Date: Fri, 2 Jul 2010 09:29:25 +0300 From: "Kirill A. Shutemov" To: Russell King Cc: g@shutemov.name, Greg KH , linux-kernel@vger.kernel.org, stable@kernel.org, stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Anfei Zhou Subject: Re: [patch 071/149] ARM: 6166/1: Proper prefetch abort handling on pre-ARMv6 Message-ID: <20100702062925.GA11877@shutemov.name> References: <20100701175144.GA2116@kroah.com> <20100701173212.785441106@clark.site> <20100701221420.GA10481@shutemov.name> <20100701221728.GA12187@suse.de> <20100701222541.GB10481@shutemov.name> <20100701224837.GA27389@flint.arm.linux.org.uk> <20100701225911.GC10481@shutemov.name> <20100701231207.GB27389@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100701231207.GB27389@flint.arm.linux.org.uk> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1332 Lines: 35 On Fri, Jul 02, 2010 at 12:12:07AM +0100, Russell King wrote: > On Fri, Jul 02, 2010 at 01:59:11AM +0300, Kirill A. Shutemov wrote: > > On Thu, Jul 01, 2010 at 11:48:37PM +0100, Russell King wrote: > > > One possibility is that for some reason you're using the legacy prefetch > > > abort code or pre-IFSR code, which will always tell the kernel that its > > > a translation fault - and in this case, this patch would improve the > > > situation. What kernel version are you using? > > > > 2.6.32 > > Should be recent enough. > > > If you run this test in loop on kernel without the patch you'll finally > > get hung instead SIGSEGV. > > > > It seems the patch fixes more than it was written for. :) > > Have you investigated the IFSR and IFAR values, and the corresponding > page table state? In oprofile dump, I saw do_PrefetchAbort() and do_translation_fault() at the top, so I guess IFSR is 5. I don't known value IFAR, but I'll see. > I'm not going to be able to run your test code for > a few days. It's only few minutes or less if you are lucky. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/