Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757750Ab0GBHKz (ORCPT ); Fri, 2 Jul 2010 03:10:55 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:61294 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756793Ab0GBHKy convert rfc822-to-8bit (ORCPT ); Fri, 2 Jul 2010 03:10:54 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=dIOrx99iPaX4YDjT01pUJ/3mqd6tDZSMRUxCxUIAkAiDYjZkyWqrVdhkLmrwCWcgoi rvAY9KjZ7bF7uhx1LKtCmfZpfgMCCWZHPl72vqS+65H8jGb96hfxqgzPvxNjuG2shUJH m4a026vVyiOEF5IY29/EksRAZcBzdNkQOH0cw= MIME-Version: 1.0 In-Reply-To: <20100701132515.GC32541@faui48a.informatik.uni-erlangen.de> References: <20100701132515.GC32541@faui48a.informatik.uni-erlangen.de> Date: Fri, 2 Jul 2010 16:10:53 +0900 Message-ID: Subject: Re: [PATCH 29/33] Removing dead SND_SOC_SMDK2443_WM9710 From: Jassi Brar To: Christoph Egger Cc: Ben Dooks , Russell King , Mark Brown , Jassi Brar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vamos@i4.informatik.uni-erlangen.de Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2048 Lines: 52 On Thu, Jul 1, 2010 at 10:25 PM, Christoph Egger wrote: > On Thu, Jul 01, 2010 at 09:55:47PM +0900, Jassi Brar wrote: >> On Thu, Jul 1, 2010 at 1:03 AM, Christoph Egger wrote: >> > SND_SOC_SMDK2443_WM9710 doesn't exist in Kconfig, therefore removing >> > all references for it from the source code. >> I'd rather have the code compiled unconditionally. > > OK that would be done by the patch below > > ---- > From: Christoph Egger > Date: Wed, 30 Jun 2010 17:18:52 +0200 > Subject: [PATCH 29/33] Removing dead SND_SOC_SMDK2443_WM9710 > > SND_SOC_SMDK2443_WM9710 doesn't exist in Kconfig, therefore removing > all references for it from the source code, building the parts > unconditionally > > Signed-off-by: Christoph Egger > --- >  arch/arm/mach-s3c2443/mach-smdk2443.c |    4 ---- >  1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-s3c2443/mach-smdk2443.c b/arch/arm/mach-s3c2443/mach-smdk2443.c > index 4c863d3..764144a 100644 > --- a/arch/arm/mach-s3c2443/mach-smdk2443.c > +++ b/arch/arm/mach-s3c2443/mach-smdk2443.c > @@ -106,9 +106,7 @@ static struct platform_device *smdk2443_devices[] __initdata = { >        &s3c_device_wdt, >        &s3c_device_i2c0, >        &s3c_device_hsmmc0, > -#ifdef CONFIG_SND_SOC_SMDK2443_WM9710 >        &s3c_device_ac97, > -#endif This is ok provided 2440 support is included. >  }; > >  static void __init smdk2443_map_io(void) > @@ -122,9 +120,7 @@ static void __init smdk2443_machine_init(void) >  { >        s3c_i2c0_set_platdata(NULL); > > -#ifdef CONFIG_SND_SOC_SMDK2443_WM9710 >        s3c24xx_ac97_setup_gpio(S3C24XX_AC97_GPE0); > -#endif This gpio setup is nowhere implemented. So might as well discard it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/