Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757821Ab0GBIbr (ORCPT ); Fri, 2 Jul 2010 04:31:47 -0400 Received: from one.firstfloor.org ([213.235.205.2]:42303 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755748Ab0GBIbp (ORCPT ); Fri, 2 Jul 2010 04:31:45 -0400 Date: Fri, 2 Jul 2010 10:31:43 +0200 From: Andi Kleen To: Naoya Horiguchi Cc: Andi Kleen , Andrew Morton , Mel Gorman , Wu Fengguang , "Jun'ichi Nomura" , linux-mm , LKML Subject: Re: [PATCH 1/7] hugetlb: add missing unlock in avoidcopy path in hugetlb_cow() Message-ID: <20100702083143.GC12221@basil.fritz.box> References: <1278049646-29769-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1278049646-29769-2-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278049646-29769-2-git-send-email-n-horiguchi@ah.jp.nec.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 17 On Fri, Jul 02, 2010 at 02:47:20PM +0900, Naoya Horiguchi wrote: > This patch fixes possible deadlock in hugepage lock_page() > by adding missing unlock_page(). > > libhugetlbfs test will hit this bug when the next patch in this > patchset ("hugetlb, HWPOISON: move PG_HWPoison bit check") is applied. This looks like a general bug fix that should be merged ASAP? Or do you think this cannot be hit at all without the other patches? -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/