Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757889Ab0GBIcL (ORCPT ); Fri, 2 Jul 2010 04:32:11 -0400 Received: from imr3.ericy.com ([198.24.6.13]:41563 "EHLO imr3.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755748Ab0GBIcG (ORCPT ); Fri, 2 Jul 2010 04:32:06 -0400 Date: Fri, 2 Jul 2010 01:31:44 -0700 From: Guenter Roeck To: Jean Delvare CC: Jim Cromie , H Hartley Sweeten , Andrew Morton , Ethan Lawrence , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , "lars4910@hotmail.com" , "birdie@permonline.ru" , "jadcock@cox.net" Subject: Re: [PATCH/RFC] hwmon: Add support for W83667HG-B Message-ID: <20100702083144.GD12911@ericsson.com> References: <1278021735-21188-1-git-send-email-guenter.roeck@ericsson.com> <20100702092011.0acd753f@hyperion.delvare> <20100702080704.GA12911@ericsson.com> <20100702101345.6fe9d27a@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20100702101345.6fe9d27a@hyperion.delvare> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1415 Lines: 35 On Fri, Jul 02, 2010 at 04:13:45AM -0400, Jean Delvare wrote: > On Fri, 2 Jul 2010 01:07:04 -0700, Guenter Roeck wrote: > > On Fri, Jul 02, 2010 at 03:20:11AM -0400, Jean Delvare wrote: > > > On Thu, 1 Jul 2010 15:02:15 -0700, Guenter Roeck wrote: > > > > @@ -63,6 +64,7 @@ static const char * w83627ehf_device_names[] = { > > > > "w83627dhg", > > > > "w83627dhg", > > > > "w83667hg", > > > > + "w83667hg-b", > > > > > > Dashes aren't allowed in hwmon device names. For consistency with what > > > we did for the W83627DHG-Pg, you should simply drop the "-b". It's a small > > > detail of little interest for the user anyway. > > > > Ok. Actually, since the only real difference was in the registers which > > are not not used anywhere, I'll drop the enum type (w83667hg_b) as well. > > Makes sense. It can be added later if needed. > > > I'll also add a check for the HG-I. > > Do you have a datasheet for that one too? > No. However, since we have a tester, we will have test coverage, so I figured it should be worth a try. If it doesn't work I can still drop it from the final patch. I suspect it is the same as the HG with a different chip ID. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/