Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758045Ab0GBJI5 (ORCPT ); Fri, 2 Jul 2010 05:08:57 -0400 Received: from one.firstfloor.org ([213.235.205.2]:42593 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756878Ab0GBJIz (ORCPT ); Fri, 2 Jul 2010 05:08:55 -0400 Date: Fri, 2 Jul 2010 11:08:54 +0200 From: Andi Kleen To: Naoya Horiguchi Cc: Andi Kleen , Andrew Morton , Mel Gorman , Wu Fengguang , "Jun'ichi Nomura" , linux-mm , LKML Subject: Re: [PATCH 3/7] hugetlb: add allocate function for hugepage migration Message-ID: <20100702090854.GD12221@basil.fritz.box> References: <1278049646-29769-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1278049646-29769-4-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278049646-29769-4-git-send-email-n-horiguchi@ah.jp.nec.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 18 On Fri, Jul 02, 2010 at 02:47:22PM +0900, Naoya Horiguchi wrote: > We can't use existing hugepage allocation functions to allocate hugepage > for page migration, because page migration can happen asynchronously with > the running processes and page migration users should call the allocation > function with physical addresses (not virtual addresses) as arguments. I looked through this patch and didn't see anything bad. Some more eyes familiar with hugepages would be good though. Since there are now so many different allocation functions some comments on when they should be used may be useful too -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/