Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756875Ab0GBLZY (ORCPT ); Fri, 2 Jul 2010 07:25:24 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:39716 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754438Ab0GBLZW (ORCPT ); Fri, 2 Jul 2010 07:25:22 -0400 X-AuditID: b753bd60-a8a04ba000007d15-0c-4c2dcc9fe862 Message-ID: <4C2DCC9D.1020001@hitachi.com> Date: Fri, 02 Jul 2010 20:25:17 +0900 From: Masami Hiramatsu Organization: Systems Development Lab., Hitachi, Ltd., Japan User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Steven Rostedt , Ananth N Mavinakayanahalli , Arnaldo Carvalho de Melo , LKML Subject: Re: [PATCHv7 2.6.35-rc3-tip 11/11] perf: perf interface for uprobes References: <20100629183454.32537.63582.sendpatchset@localhost6.localdomain6> <20100629183704.32537.28871.sendpatchset@localhost6.localdomain6> <4C2C2ECC.5060700@hitachi.com> In-Reply-To: <4C2C2ECC.5060700@hitachi.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== X-FMFTCR: RANGEC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 41 Masami Hiramatsu wrote: > Srikar Dronamraju wrote: >> perf: perf interface for uprobes >> >> Changelog from v4: Merged to 2.6.35-rc3-tip. >> >> Changelog from v3: (addressed comments from Masami Hiramatsu) >> * Every process id has a different group name. >> * event name starts with function name. >> * If vaddr is specified, event name has vaddr appended >> along with function name, (this is to avoid subsequent probes >> using same event name.) >> * warning if -p and --list options are used together. >> >> Also dso can either be a short name or absolute path. >> >> Enhances perf probe to accept pid and user vaddr. >> Provides very basic support for uprobes. > > It's unsure what will happen if user sets a probe by line number... > I'd like to suggest you if need_dwarf && uid, it should show an error message. > But other parts are OK for me. I've checked that perf probe was stopped by SEGV in convert_name_to_addr() with below options. # perf probe -u 2403 hoge.c:100 because pp->function == NULL. Thank you, -- Masami HIRAMATSU 2nd Research Dept. Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/