Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759155Ab0GBQQv (ORCPT ); Fri, 2 Jul 2010 12:16:51 -0400 Received: from imr3.ericy.com ([198.24.6.13]:51488 "EHLO imr3.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758945Ab0GBQQu (ORCPT ); Fri, 2 Jul 2010 12:16:50 -0400 Date: Fri, 2 Jul 2010 09:15:21 -0700 From: Guenter Roeck To: Jean Delvare CC: Jim Cromie , H Hartley Sweeten , Andrew Morton , Ethan Lawrence , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , "lars4910@hotmail.com" , "birdie@permonline.ru" , "jadcock@cox.net" Subject: Re: [PATCH/RFC] hwmon: Add support for W83667HG-B Message-ID: <20100702161521.GA14580@ericsson.com> References: <1278021735-21188-1-git-send-email-guenter.roeck@ericsson.com> <20100702092011.0acd753f@hyperion.delvare> <20100702080704.GA12911@ericsson.com> <20100702101345.6fe9d27a@hyperion.delvare> <20100702083144.GD12911@ericsson.com> <20100702115123.18e95e14@hyperion.delvare> <20100702140944.GA14032@ericsson.com> <20100702165903.3d9dcdab@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20100702165903.3d9dcdab@hyperion.delvare> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1585 Lines: 35 On Fri, Jul 02, 2010 at 10:59:03AM -0400, Jean Delvare wrote: > On Fri, 2 Jul 2010 07:09:44 -0700, Guenter Roeck wrote: > > On Fri, Jul 02, 2010 at 05:51:23AM -0400, Jean Delvare wrote: > > > On Fri, 2 Jul 2010 01:31:44 -0700, Guenter Roeck wrote: > > > > On Fri, Jul 02, 2010 at 04:13:45AM -0400, Jean Delvare wrote: > > > > > On Fri, 2 Jul 2010 01:07:04 -0700, Guenter Roeck wrote: > > > > > > I'll also add a check for the HG-I. > > > > > > > > > > Do you have a datasheet for that one too? > > > > > > > > > No. However, since we have a tester, we will have test coverage, > > > > so I figured it should be worth a try. If it doesn't work > > > > I can still drop it from the final patch. > > > > > > FYI, I have a datasheet, which unfortunately I am not allowed to share. > > > Please let me know if you want me to look up something for you. > > > > > How about the changed registers ? Would give us an idea if the chip is closer to > > 667 or to 667-B. > > There is no summary of this available. The only way is to go through > both datasheets and compare all registers in sequence. This takes time, > which is exactly why I couldn't find the time to do it :( > Yes, I noticed. Changes can be quite subtle, too. I'll remove the HG-I chip detection from the next patch rev unless I manage to get a datasheet as well. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/