Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759433Ab0GBRWp (ORCPT ); Fri, 2 Jul 2010 13:22:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47211 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759382Ab0GBRWh (ORCPT ); Fri, 2 Jul 2010 13:22:37 -0400 Date: Fri, 2 Jul 2010 14:03:03 -0300 From: Marcelo Tosatti To: Xiao Guangrong Cc: Avi Kivity , LKML , KVM list Subject: Re: [PATCH v4 5/6] KVM: MMU: combine guest pte read between walk and pte prefetch Message-ID: <20100702170303.GC25969@amt.cnet> References: <4C2C9DC0.8050607@cn.fujitsu.com> <4C2C9E6C.2040803@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C2C9E6C.2040803@cn.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 26 On Thu, Jul 01, 2010 at 09:55:56PM +0800, Xiao Guangrong wrote: > Combine guest pte read between guest pte walk and pte prefetch > > Signed-off-by: Xiao Guangrong > --- > arch/x86/kvm/paging_tmpl.h | 48 ++++++++++++++++++++++++++++++------------- > 1 files changed, 33 insertions(+), 15 deletions(-) Can't do this, it can miss invlpg: vcpu0 vcpu1 read guest ptes modify guest pte invlpg instantiate stale guest pte See how the pte is reread inside fetch with mmu_lock held. Otherwise the patchset looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/