DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=caP4Bjo+RVO6RbR3hvviHhFXl6m1IGfYoeO75hX7XW+A8pbpuYPBk9YFBUXp9zP+1LKeq2fOyYnZw9UDl5jYFlBzUNlJ69wYSe7G/RjvidpgDhUGok+ZoV+bPkRERal8;
Date: Fri, 2 Jul 2010 16:13:46 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
       lrodriguez@atheros.com, maximlevitsky@gmail.com
Subject: Re: [PATCH] PCI: Default PCIe ASPM control to on and require
 !EMBEDDED to disable
Message-ID: <20100702161346.78896982@virtuousgeek.org>
In-Reply-To: <1277240583-5607-1-git-send-email-mjg@redhat.com>
References: <1277240583-5607-1-git-send-email-mjg@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1493
Lines: 34

On Tue, 22 Jun 2010 17:03:03 -0400
Matthew Garrett <mjg@redhat.com> wrote:

> The CONFIG_PCIEASPM option is confusing and potentially dangerous. ASPM is
> a hardware mediated feature rather than one under direct OS control, and
> even if the config option is disabled the system firmware may have turned
> on ASPM on various bits of hardware. This can cause problems later -
> various hardware that claims to support ASPM does a poor job of it and may
> hang or cause other difficulties. The kernel is able to recognise this in
> many cases and disable the ASPM functionality, but only if CONFIG_PCIEASPM
> is enabled.
> 
> Given that in its default configuration this option will either leave the
> hardware as it was originally or disable hardware functionality that may
> cause problems, it should by default y. The only reason to disable it
> ought to be to reduce code size, so make it dependent on CONFIG_EMBEDDED.
> 
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> Cc: lrodriguez@atheros.com
> Cc: maximlevitsky@gmail.com
> ---
>  drivers/pci/pcie/Kconfig |   20 ++++++++++++++------
>  1 files changed, 14 insertions(+), 6 deletions(-)
> 

Applied to my linux-next branch, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/