Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753987Ab0GCHjt (ORCPT ); Sat, 3 Jul 2010 03:39:49 -0400 Received: from bamako.nerim.net ([62.4.17.28]:64241 "EHLO bamako.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753216Ab0GCHjr (ORCPT ); Sat, 3 Jul 2010 03:39:47 -0400 Date: Sat, 3 Jul 2010 09:39:43 +0200 From: Jean Delvare To: Guenter Roeck Cc: Jim Cromie , H Hartley Sweeten , Andrew Morton , Ethan Lawrence , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , "lars4910@hotmail.com" , "birdie@permonline.ru" , "jadcock@cox.net" Subject: Re: [PATCH/RFC] hwmon: Add support for W83667HG-B Message-ID: <20100703093943.1d5febc4@hyperion.delvare> In-Reply-To: <20100702161521.GA14580@ericsson.com> References: <1278021735-21188-1-git-send-email-guenter.roeck@ericsson.com> <20100702092011.0acd753f@hyperion.delvare> <20100702080704.GA12911@ericsson.com> <20100702101345.6fe9d27a@hyperion.delvare> <20100702083144.GD12911@ericsson.com> <20100702115123.18e95e14@hyperion.delvare> <20100702140944.GA14032@ericsson.com> <20100702165903.3d9dcdab@hyperion.delvare> <20100702161521.GA14580@ericsson.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i586-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 30 On Fri, 2 Jul 2010 09:15:21 -0700, Guenter Roeck wrote: > On Fri, Jul 02, 2010 at 10:59:03AM -0400, Jean Delvare wrote: > > On Fri, 2 Jul 2010 07:09:44 -0700, Guenter Roeck wrote: > > > On Fri, Jul 02, 2010 at 05:51:23AM -0400, Jean Delvare wrote: > > > > FYI, I have a datasheet, which unfortunately I am not allowed to share. > > > > Please let me know if you want me to look up something for you. > > > > > > > How about the changed registers ? Would give us an idea if the chip is closer to > > > 667 or to 667-B. > > > > There is no summary of this available. The only way is to go through > > both datasheets and compare all registers in sequence. This takes time, > > which is exactly why I couldn't find the time to do it :( > > > Yes, I noticed. Changes can be quite subtle, too. > > I'll remove the HG-I chip detection from the next patch rev > unless I manage to get a datasheet as well. I agree. The 667HG-B support seems to be easier to get, and more urgent too, judging by the number of requests. Let's get this tested and upstream first, and then we see what can be done for the 677HG-I. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/