Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756926Ab0GDHtM (ORCPT ); Sun, 4 Jul 2010 03:49:12 -0400 Received: from s15228384.onlinehome-server.info ([87.106.30.177]:52829 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756257Ab0GDHtJ (ORCPT ); Sun, 4 Jul 2010 03:49:09 -0400 Date: Sun, 4 Jul 2010 09:51:10 +0200 From: Borislav Petkov To: Kulikov Vasiliy Cc: Kernel Janitors , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , Tejun Heo , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 07/19] arch/x86/kernel: use for_each_pci_dev() Message-ID: <20100704075110.GA5356@aftab> References: <1278173040-11643-1-git-send-email-segooon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278173040-11643-1-git-send-email-segooon@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 51 From: Kulikov Vasiliy Date: Sat, Jul 03, 2010 at 12:03:59PM -0400 > Use for_each_pci_dev() to simplify the code. > > Signed-off-by: Kulikov Vasiliy Acked-by: Borislav Petkov > --- > arch/x86/kernel/k8.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/k8.c b/arch/x86/kernel/k8.c > index 0f7bc20..0ea4b35 100644 > --- a/arch/x86/kernel/k8.c > +++ b/arch/x86/kernel/k8.c > @@ -27,11 +27,10 @@ EXPORT_SYMBOL(k8_northbridges); > > static struct pci_dev *next_k8_northbridge(struct pci_dev *dev) > { > - do { > - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev); > - if (!dev) > + for_each_pci_dev(dev) { > + if (pci_match_id(&k8_nb_ids[0], dev)) > break; > - } while (!pci_match_id(&k8_nb_ids[0], dev)); > + } > return dev; > } > > -- > 1.7.0.4 > > -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/