Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757905Ab0GDQvF (ORCPT ); Sun, 4 Jul 2010 12:51:05 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:36000 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573Ab0GDQvD (ORCPT ); Sun, 4 Jul 2010 12:51:03 -0400 Message-ID: <4C30BBF0.1030801@cs.helsinki.fi> Date: Sun, 04 Jul 2010 19:50:56 +0300 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: David Rientjes CC: Xiaotian Feng , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Matt Mackall , Vegard Nossum , Dmitry Monakhov , Catalin Marinas Subject: Re: [PATCH V2] slab: fix caller tracking on !CONFIG_DEBUG_SLAB && CONFIG_TRACING References: <1277891842-18898-1-git-send-email-dfeng@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 26 David Rientjes wrote: > On Wed, 30 Jun 2010, Xiaotian Feng wrote: > >> In slab, all __xxx_track_caller is defined on CONFIG_DEBUG_SLAB || CONFIG_TRACING, >> thus caller tracking function should be worked for CONFIG_TRACING. But if >> CONFIG_DEBUG_SLAB is not set, include/linux/slab.h will define xxx_track_caller to >> __xxx() without consideration of CONFIG_TRACING. This will break the caller tracking >> behaviour then. >> >> Signed-off-by: Xiaotian Feng >> Cc: Christoph Lameter >> Cc: Pekka Enberg >> Cc: Matt Mackall >> Cc: Vegard Nossum >> Cc: Dmitry Monakhov >> Cc: Catalin Marinas >> Cc: David Rientjes > > Acked-by: David Rientjes Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/