Date: Mon, 5 Jul 2010 12:40:35 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Ali Gholami Rudi <ali@rudi.ir>, Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: dfeng@redhat.com, x86@kernel.org, venki@google.com, tglx@linutronix.de,
       suresh.b.siddha@intel.com, mingo@redhat.com,
       linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [regression] commit 6a4f3b52 causes invalid memtype
Message-ID: <20100705104035.GA28190@elte.hu>
References: <20100507075128@tarekhel>
 <4C319D61.5090002@redhat.com>
 <20100507092842@tarekhel>
 <4C31A7A0.1020800@redhat.com>
 <4c31ac7b.J+CU0Yt+zKZ9ho1fjKvu6Z1v@tarekhel>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4c31ac7b.J+CU0Yt+zKZ9ho1fjKvu6Z1v@tarekhel>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1160
Lines: 35


* Ali Gholami Rudi <ali@rudi.ir> wrote:

> Xiaotian Feng <dfeng@redhat.com> wrote:
> > On 07/05/2010 05:28 PM, Ali Gholami Rudi wrote:
> > > Xiaotian Feng<dfeng@redhat.com>  wrote:
> > >> Could you please try following commit in -tip tree?
> > >>
> > >> commit 2463eb8b3093995e09a0d41b3d78ee0cf5fb4249
> > >> Author: Peter Zijlstra<peterz@infradead.org>
> > >> Date:   Sat May 29 15:31:43 2010 +0200
> > >>
> > >>       rbtree: Undo augmented trees performance damage
> > >
> > > Where can I get it?  I couldn't find it either in
> > > Linus' or x86 repo tip.
> > http://git.kernel.org/tip/2463eb8b3093995e09a0d41b3d78ee0cf5fb4249
> 
> It does fix it.

Hm, interesting. That's a pure performance fix - so why does it fix a 
regression?

Does Peter's augmented rbtrees improvements fix a bug too, as a side-effect? 
If yes then we need to accelerate that commit - right now it's aimed for 
v2.6.36.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/