Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756634Ab0GFAx4 (ORCPT ); Mon, 5 Jul 2010 20:53:56 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:49217 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752897Ab0GFAxy (ORCPT ); Mon, 5 Jul 2010 20:53:54 -0400 Message-ID: <4C327DBA.9020309@cn.fujitsu.com> Date: Tue, 06 Jul 2010 08:50:02 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Marcelo Tosatti CC: Avi Kivity , LKML , KVM list Subject: Re: [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF References: <4C2C9DC0.8050607@cn.fujitsu.com> <4C2C9E45.1040304@cn.fujitsu.com> <20100702165432.GB25969@amt.cnet> <4C2EF00A.2090406@cn.fujitsu.com> <20100705120118.GB15826@amt.cnet> In-Reply-To: <20100705120118.GB15826@amt.cnet> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 26 Marcelo Tosatti wrote: > On Sat, Jul 03, 2010 at 04:08:42PM +0800, Xiao Guangrong wrote: >> >> Marcelo Tosatti wrote: >> >>>> + >>>> + if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL)) >>>> + break; >>> BTW, doesnt sync_page also lack reserved bit checking? (unrelated to >>> this patch). >>> >> I think it's not since if EPT is enabled, no unsync page exist, the sync page >> path can't be trigged. :-) > > What i mean is, why the sync_page path does not require reserved bit > checking? (EPT disabled). > Oh, i think we should check it, i'll post a patch to fix it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/