References: <1278195310-25590-1-git-send-email-arnd@arndb.de> <20100705195837.GF5240@nowhere> <1278378690.3070.6.camel@localhost> <201007061335.00264.arnd@arndb.de>
Message-Id: <202899B0-BADE-4CD0-B0E4-1A2FC99397D6@themaw.net>
From: Ian Kent <raven@themaw.net>
To: Arnd Bergmann <arnd@arndb.de>
In-Reply-To: <201007061335.00264.arnd@arndb.de>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 8BIT
Mime-Version: 1.0 (iPad Mail 7B367)
Subject: Re: [PATCH 3/6] autofs/autofs4: move compat_ioctl handling into fs
Date: Tue, 6 Jul 2010 21:17:16 +0800
Cc: Frederic Weisbecker <fweisbec@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       John Kacur <jkacur@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
       "autofs@linux.kernel.org" <autofs@linux.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1040
Lines: 23


On 06/07/2010, at 7:35 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> 
> Well, the only use of the BKL in autofs4 is in the ioctl function. You
> can probably replace that trivially with a global mutex, but from a quick
> inspection, even that should not be needed: The only ioctl command in
> autofs4 that does not already seem to have adequate locking is
> autofs4_get_set_timeout, which is even easier to change and still harmless
> if you don't do it at all.

That's right of course.

Even this shouldn't be a problem as it is called by a single instance, per autofs mount, of the daemon only. A fair amount of effort has gone into trying to make the autofs4 module independent of the BKL over time. However I would still rather not do the change concurrently with the ioctl changes.

Ian
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/