Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754262Ab0GFPj1 (ORCPT ); Tue, 6 Jul 2010 11:39:27 -0400 Received: from cantor.suse.de ([195.135.220.2]:58828 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835Ab0GFPjZ (ORCPT ); Tue, 6 Jul 2010 11:39:25 -0400 Subject: Re: [PATCH] enclosure: fix lost return From: James Bottomley To: Kulikov Vasiliy Cc: Kernel Janitors , Tejun Heo , David Brownell , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-scsi In-Reply-To: <1278430088-9761-1-git-send-email-segooon@gmail.com> References: <1278430088-9761-1-git-send-email-segooon@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 06 Jul 2010 10:39:19 -0500 Message-ID: <1278430759.2854.80.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 38 On Tue, 2010-07-06 at 19:28 +0400, Kulikov Vasiliy wrote: > Useless statement must be return with argument. > > This patch silences a compiler warning: > drivers/misc/enclosure.c: In function ‘enclosure_component_register’: > drivers/misc/enclosure.c:289: warning: ignoring return value of ‘ERR_PTR’, declared with attribute warn_unused_result > > Signed-off-by: Kulikov Vasiliy > --- > drivers/misc/enclosure.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c > index 48c84a5..9ae7bef 100644 > --- a/drivers/misc/enclosure.c > +++ b/drivers/misc/enclosure.c > @@ -286,7 +286,7 @@ enclosure_component_register(struct enclosure_device *edev, > > err = device_register(cdev); > if (err) > - ERR_PTR(err); > + return ERR_PTR(err); Well, the patch isn't quite correct, but I think I win a prize for working out what the correct patch was and then forgetting to apply it: http://marc.info/?l=linux-scsi&m=126843630320666 I've actually put it in my tree this time ... James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/