DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding:message-id;
        b=e23OKz0lm2jNRZJvQvxCSkVmmdUu7sNgKkWICE9kkxSfa2I5iJkhPKh6+UwTjfDHVs
         RTLcfWoW2JOZrRoErgXtd7fiNKYJMDJnRLm4kOjUQNvD8b6B1y9/dCx0GDoWMgCzUSXd
         SoGTagBJAj1PUa9sCZUHmUfoyIT6rhbfn6vpg=
From: "Sergey V." <sftp.mtuci@gmail.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used
Date: Tue, 6 Jul 2010 22:05:30 +0400
User-Agent: KMail/1.13.3 (Linux/2.6.33.5; KDE/4.4.3; x86_64; ; )
Cc: minyard@acm.org, akpm@linux-foundation.org,
       openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       jillsmitt@linuxcenter.kz
References: <1278436544-6091-1-git-send-email-justinmattock@gmail.com>
In-Reply-To: <1278436544-6091-1-git-send-email-justinmattock@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201007062205.30616.sftp.mtuci@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1626
Lines: 53

On Tuesday 06 of July 2010 21:15:44 Justin P. Mattock wrote:
> This is version two of fixing a warning message generated by GCC
>   CC [M]  drivers/char/ipmi/ipmi_si_intf.o
> drivers/char/ipmi/ipmi_si_intf.c: In function 'try_init_spmi':
> drivers/char/ipmi/ipmi_si_intf.c:2016:8: warning: variable 'addr_space' set 
but not used
> 
> And also updates a broken web address.
> 
>  Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> 
> ---

Hello Justin.

[...]
> @@ -2021,10 +2020,6 @@ static __devinit int try_init_spmi(struct SPMITable 
*spmi)
>  	}
>  
>  	if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
> -		addr_space = IPMI_MEM_ADDR_SPACE;
> -	else
> -		addr_space = IPMI_IO_ADDR_SPACE;
> -
>  	info = kzalloc(sizeof(*info), GFP_KERNEL);
>  	if (!info) {
>  		printk(KERN_ERR PFX "Could not allocate SI data (3)\n");

This looks like after applying this patch 'info = ...' will be part of
if statement (without indent before 'info = ...')

	if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
		info = kzalloc(sizeof(*info), GFP_KERNEL);

It's correct?

Thanks

> -- 
> 1.7.1.rc1.21.gf3bd6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/