Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755607Ab0GFSla (ORCPT ); Tue, 6 Jul 2010 14:41:30 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:21803 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754250Ab0GFSl2 (ORCPT ); Tue, 6 Jul 2010 14:41:28 -0400 Date: Tue, 6 Jul 2010 11:39:46 -0700 From: Joel Becker To: Tao Ma , Dave Chinner , Linus Torvalds , Linux Kernel , ocfs2-devel@oss.oracle.com, Dave Chinner , Christoph Hellwig , Mark Fasheh Subject: Re: [Ocfs2-devel] [PATCH 2/2] ocfs2: No need to zero pages past i_size. i_size v2 Message-ID: <20100706183946.GB17961@mail.oracle.com> Mail-Followup-To: Tao Ma , Dave Chinner , Linus Torvalds , Linux Kernel , ocfs2-devel@oss.oracle.com, Dave Chinner , Christoph Hellwig , Mark Fasheh References: <20100702224912.GC5800@mail.oracle.com> <20100703213219.GB21262@mail.oracle.com> <20100703213343.GC21262@mail.oracle.com> <4C30A4FD.4030900@oracle.com> <20100706070918.GD13023@mail.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100706070918.GD13023@mail.oracle.com> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.20 (2009-06-14) X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A0B020B.4C3378B4.00F1:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1110 Lines: 34 On Tue, Jul 06, 2010 at 12:09:19AM -0700, Joel Becker wrote: > On Sun, Jul 04, 2010 at 11:13:01PM +0800, Tao Ma wrote: > > > if (new) { > > > wc->w_num_pages = ocfs2_pages_per_cluster(inode->i_sb); > > > start = ocfs2_align_clusters_to_page_index(inode->i_sb, cpos); > > >+ /* This is the index *past* the write */ > > >+ end_index = ((user_pos + user_len)>> PAGE_CACHE_SHIFT) + 1; > > should it be > > end_index = ((user_pos + user_len - 1) >> PAGE_CACHE_SHIFT) + 1? > > Maybe. Gotta think about it and test. I think you're right. Since there are other changes too, I'm going to add this in and test it. Joel -- "I'm drifting and drifting Just like a ship out on the sea. Cause I ain't got nobody, baby, In this world to care for me." Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/