Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333Ab0GGBuF (ORCPT ); Tue, 6 Jul 2010 21:50:05 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:59618 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814Ab0GGBuC (ORCPT ); Tue, 6 Jul 2010 21:50:02 -0400 Date: Tue, 6 Jul 2010 21:50:00 -0400 From: Christoph Hellwig To: Arnd Bergmann Cc: Jens Axboe , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, John Kacur , Frederic Weisbecker , linux-scsi@vger.kernel.org Subject: Re: [PATCH 2/6] block: push down BKL into .open and .release Message-ID: <20100707015000.GC2950@infradead.org> References: <1278193640-24223-1-git-send-email-arnd@arndb.de> <1278193640-24223-3-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278193640-24223-3-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 640 Lines: 14 I might be missing something, but this doesn't actually push the BKL anyway. It adds duplicate BKL locking inside the ->open and ->release methods without actually removing it in the callers. That's a pretty pointless thing to do. If you're not feeling confident enough about touching block_dev.c I can look into that part of the pushdown, but this patch on it's own is not actually useful. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/