Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753913Ab0GGCG0 (ORCPT ); Tue, 6 Jul 2010 22:06:26 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:50384 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037Ab0GGCGZ (ORCPT ); Tue, 6 Jul 2010 22:06:25 -0400 Date: Tue, 6 Jul 2010 22:06:23 -0400 From: Christoph Hellwig To: Arnd Bergmann Cc: Jens Axboe , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, John Kacur , Frederic Weisbecker , linux-scsi@vger.kernel.org, "James E.J. Bottomley" Subject: Re: [PATCH 6/6] scsi/sd: remove big kernel lock Message-ID: <20100707020623.GA28839@infradead.org> References: <1278193640-24223-1-git-send-email-arnd@arndb.de> <1278193640-24223-7-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278193640-24223-7-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 394 Lines: 8 This looks fine, although relying on the bd_mutex held in the caller for ->openers seems a bit fragile. At least add a big comment about this fact. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/