Date: Wed, 7 Jul 2010 12:30:18 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
       KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH v5 8/9] KVM: MMU: combine guest pte read between fetch
 and pte prefetch
Message-ID: <20100707153018.GA15420@amt.cnet>
References: <4C330918.6040709@cn.fujitsu.com>
 <4C330A9A.9030106@cn.fujitsu.com>
 <20100706195254.GA4311@amt.cnet>
 <4C33D703.4090208@cn.fujitsu.com>
 <20100707130705.GA4293@amt.cnet>
 <4C347D1C.9000100@cn.fujitsu.com>
 <20100707134010.GA4566@amt.cnet>
 <4C348ABC.20206@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C348ABC.20206@cn.fujitsu.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1381
Lines: 46

On Wed, Jul 07, 2010 at 10:10:04PM +0800, Xiao Guangrong wrote:
> 
> 
> Marcelo Tosatti wrote:
> 
> >>>>
> >>>> It reads the 16 aligned items around sptep's corresponding gpte and this gpte
> >>>> is also in this area. :-)
> >>> But you removed that in patch 8?
> >>>
> >> Oh, i just want it good for review, you mean it's better let patch 7 and 8 in one patch?
> > 
> > I mean patch 7 is wrong because it removes rereading of gpte, with
> > mmu_lock held, in the prefetch patch.
> > 
> 
> Marcelo,
> 
> Sorry, i don't understand it clearly.
> 
> In the patch 7, we read gpte like this:
> 
> 	hold mmu_lock
> 	atomic read gpte during guest mapping's checking in 'fetch' path
> 	atomic read 16 aligned items chunk (include gpte) in pte_prefetch path
> 	release mmu_lock
> 
> And in the patch 8, we do it like this:
> 	hold mmu_lock
> 
> 	atomic read 16 aligned items chunk (include gpte) in 'fetch' path, and
>         saved this chunk to gw->prefetch_ptes
> 	
>         get gptes form gw->prefetch_ptes in pte_prefetch path
> 
> 	release mmu_lock
> 
> Could you please tell me where is wrong?

You're right. Patchset looks good to me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/