Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757509Ab0GGTwS (ORCPT ); Wed, 7 Jul 2010 15:52:18 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:33524 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755102Ab0GGTwR (ORCPT ); Wed, 7 Jul 2010 15:52:17 -0400 Date: Wed, 7 Jul 2010 15:52:09 -0400 From: Christoph Hellwig To: FUJITA Tomonori Cc: axboe@kernel.dk, hch@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] remove q->prepare_flush_fn hook Message-ID: <20100707195209.GA25635@infradead.org> References: <1278146740-8731-1-git-send-email-fujita.tomonori@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278146740-8731-1-git-send-email-fujita.tomonori@lab.ntt.co.jp> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 430 Lines: 8 One weird thing after this set is that the flush commands don't have any cmd_type. I think it should be set to REQ_TYPE_FS, even if we might be resetting it inside the driver for now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/