Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757701Ab0GGVnR (ORCPT ); Wed, 7 Jul 2010 17:43:17 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:57426 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757667Ab0GGVkm (ORCPT ); Wed, 7 Jul 2010 17:40:42 -0400 From: Arnd Bergmann To: linux-kernel@vger.kernel.org Cc: John Kacur , Frederic Weisbecker , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , Al Viro , linux-fsdevel@vger.kernel.org Subject: [PATCH 18/18] vfs: make no_llseek the default Date: Wed, 7 Jul 2010 23:40:20 +0200 Message-Id: <1278538820-1392-19-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1278538820-1392-1-git-send-email-arnd@arndb.de> References: <1278538820-1392-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:S7RjoyxVgY1j/KqP0uSoxrxixgOD0iwrgt4eCdcP5Vu XZkuSa6QtddFCZ5MbzzHL5YIdQxxVTquGDH72sO692RCHsa4f0 CWhMyqbyaWxCxNH81xBjTIOKPwkqsQ8rMl+EF8vxeLv5lbNyup s7qdjTTp5lqJe4DLqjcKc8byVSQuX4jeDNoNbeQfZkDkgSgg9W EoC0xeOIye29PUt3/jURw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 41 All file operations now have an explicit .llseek operation pointer, so we can change the default action for future code. This makes changes the default from default_llseek to no_llseek, which always returns -ESPIPE if a user tries to seek on a file without a .llseek operation. The name of the default_llseek function remains unchanged, if anyone thinks we should change it, please speak up. Signed-off-by: Arnd Bergmann Cc: Christoph Hellwig Cc: Al Viro Cc: linux-fsdevel@vger.kernel.org --- fs/read_write.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 31c0be7..d2ed19a 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -156,7 +156,6 @@ loff_t vfs_llseek(struct file *file, loff_t offset, int origin) fn = no_llseek; if (file->f_mode & FMODE_LSEEK) { - fn = default_llseek; if (file->f_op && file->f_op->llseek) fn = file->f_op->llseek; } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/